From 0934e7337c46e2adb1d50feba88664192c5dc7c1 Mon Sep 17 00:00:00 2001 From: Drew Heavner Date: Fri, 8 Nov 2019 17:32:56 -0500 Subject: [PATCH] Fixing zipalign arguments --- lib/signing.js | 8 +++++++- src/signing.ts | 9 ++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/signing.js b/lib/signing.js index a293a57d..02987d25 100644 --- a/lib/signing.js +++ b/lib/signing.js @@ -35,7 +35,7 @@ function signApkFile(apkFile, signingKeyFile, alias, keyStorePassword, keyPasswo // Align the apk file const alignedApkFile = apkFile.replace('.apk', '-aligned.apk'); yield exec.exec(`"${zipAlign}"`, [ - '-v', '-p 4', + '-v', '-p', '4', apkFile, alignedApkFile ]); @@ -51,6 +51,12 @@ function signApkFile(apkFile, signingKeyFile, alias, keyStorePassword, keyPasswo '--out', signedApkFile, alignedApkFile ]); + // Verify + core.debug("Verifying Signed APK"); + yield exec.exec(`"${apkSigner}"`, [ + 'verify', + signedApkFile + ]); return signedApkFile; }); } diff --git a/src/signing.ts b/src/signing.ts index d47452c8..a0363318 100644 --- a/src/signing.ts +++ b/src/signing.ts @@ -28,7 +28,7 @@ export async function signApkFile( // Align the apk file const alignedApkFile = apkFile.replace('.apk', '-aligned.apk'); await exec.exec(`"${zipAlign}"`, [ - '-v', '-p 4', + '-v', '-p', '4', apkFile, alignedApkFile ]); @@ -48,6 +48,13 @@ export async function signApkFile( alignedApkFile ]); + // Verify + core.debug("Verifying Signed APK"); + await exec.exec(`"${apkSigner}"`, [ + 'verify', + signedApkFile + ]); + return signedApkFile }